Merged
Conversation
The damage for the skill was not corrected when I added support for the phys as extra damage multi for enemies
|
Thx a ton! Thought I was going insane for last few leagues looking at maven memory game. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #9756
Description of the problem being solved:
At the start of 3.27 they added a new physical damage conversion multiplier. I added support for boss skills to be correctly scaled but didn't realise that we had hardcoded some boss values that were not being pulled from the game files
The Maven Memory Game attack had its base damage effectiveness go from 12.5 in 3.26 to 3.125 in 3.27 but cause we were not exporting the skill from the game files, it just had 300% more damage from the conversion multi mod
We should really have all boss skills exported from the game files. I really do not like how we currently export them as believe that it would be far better to export the monster and their skills similarly to how we have spectres and minions
Before screenshot:
After screenshot: